WebCalendar

Merge pull request #652 from craigk5n/fix/issue-642-wizard-missing-methods fix(wizard): restore missing createAdminUser() and getUpgradeSqlCommands()

fix(wizard): restore createAdminUser() and getUpgradeSqlCommands() Commit 95c4e08 (“clean up wizard installer”) removed two WizardDatabase methods but left their callers in place, so the wizard fatals with “Call to undefined method” on PHP 8.x: – WizardDatabase::createAdminUser() — called by index.php (create-admin-user action) and headless.php. Hitting the admin-user step (e.g. a fresh env-var/Docker install adding an admin) returned HTTP 500 with an empty body, which the wizard JS reports as “Unexpected end of JSON input” (issue #642, reported by @sonntam). – WizardDatabase::getUpgradeSqlCommands() — called by index.php (get-upgrade-sql action) during the upgrade flow. Restore both. createAdminUser() is improved over the deleted version: – Stores the password with password_hash(PASSWORD_DEFAULT) to match the main app (includes/user.php) instead of md5(). – Selects the target database for mysqli, since the create-admin-user action only calls testConnection() (which does not select a DB) before this, so the INSERT would otherwise fail with “No database selected”. – Reports a specific error per backend instead of swallowing failures. Verified in a PHP 8.1 + MySQL 8.0 container: connect (no select_db) -> createAdminUser() creates an enabled admin row whose bcrypt hash passes password_verify().

Merge pull request #651 from craigk5n/fix/issue-642-wizard-mysqli-json fix(wizard): prevent “Unexpected end of JSON input” on PHP 8.1+ installs

fix(wizard): prevent “Unexpected end of JSON input” on PHP 8.1+ installs The install wizard’s WizardDatabase class is written against legacy mysqli semantics: @-suppressed calls that check ->error/->connect_error and false returns. PHP 8.1+ defaults mysqli to MYSQLI_REPORT_ERROR|MYSQLI_REPORT_STRICT, making those calls throw mysqli_sql_exception instead. The @ operator does not suppress thrown exceptions, so an uncaught exception (e.g. select_db on a not-yet-created database) becomes a fatal error. With display_errors off and the output buffer cleaned, the AJAX response body is empty, which the wizard JS surfaces as “Unexpected end of JSON input” (issue #642). – WizardDatabase: disable mysqli exception throwing in the constructor (mysqli_report(MYSQLI_REPORT_OFF)), restoring the return-false contract the class assumes across all connect/select_db/query calls at once. – index.php: add a register_shutdown_function in the API POST handler that emits a valid JSON error if any future fatal escapes, so the user sees the real problem instead of an empty body. Reproduced and verified in a PHP 8.1.21 + MySQL 8.0 container: pre-fix the select_db-on-missing-db path threw an uncaught exception (empty body); with the fix it returns clean JSON and the wizard advances to the create-db step.

fix(tools): handle mixed latin1/UTF-8 data in charset converter The latin1->utf8 converter (issue #626) assumed all non-ASCII bytes were UTF-8 wrongly stored in a latin1 column, and used a column-wide binary->utf8mb4 reinterpret. Databases upgraded over many years often hold a MIX: genuine latin1 bytes (e.g. “a-umlaut”=0xE4, “sharp-s”=0xDF) alongside double-encoded UTF-8 (0xC3A4) in the same column. Genuine latin1 bytes are not valid UTF-8, so the reinterpret step threw “Incorrect string value: \xE4…” and aborted (issue #649). Decide per value instead of per column (“fix-then-reinterpret”): 1. MODIFY column to a binary type (lossless) 2. per distinct value: keep if already valid UTF-8, else transcode latin1->UTF-8 3. MODIFY to utf8mb4 (all bytes now valid, never errors) 4. set table default charset Also: – mysqli_report(OFF) + per-column error handling so one bad column no longer aborts the run; failed columns keep raw bytes and are re-runnable – optional WEBCALENDAR_DB_* env overrides for container/test use – detection summary now counts ASCII / valid-UTF-8 / genuine-latin1 Add tests/test-latin1-conversion.sh: seeds MariaDB 10.5 with the exact failing values from #649 (plus double-encoded, ASCII, and a TEXT column), runs dry-run then conversion, and asserts the resulting bytes and charset.